feat(avatar): update to new visual language #2019
Conversation
🦋 Changeset detectedLatest commit: 9e33eb7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Add ActivityIndicator to Stacks Svelte
giamir
force-pushed
the
SPARK-61/avatar
branch
from
7ba3959 to
fcd0204
Compare
dancormier
left a comment
dancormier
left a comment
There was a problem hiding this comment.
I keep going back and forth on the size of the indicator on the 24px avatar variant 😂. I think that means it's fine! Thanks for the thoughtfulness towards this component @giamir
LGTM (once activity indicator is merged and we make sure it plays nicely with this)!
|
@CGuindon @dancormier Now that we have changed the activity indicator small size to 10x10 I opted for using the small size for both 16x and 24x avatars. Going with the big one for the 24 looked pretty odd to me. Before After Let me know if that seems sensible to you. Thank you. |
That looks |
SPARK-61
Figma
Here is what changed:
.s-avatar--indicatorclass for positioning an activity indicator element in relation to the avatar. (docs)statusprop. When set toonlineit will show an activity indicator on the avatar. (storybook)Note: This PR should be merged after the activity indicator one get merged.